Abstract glyph drawing logic as Draw trait #189
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This is separated from #185 for easier review.
The trait contains only one method, draw_line, which is going to be implemented by glyph rendering backend like swash to scale & rasterize inputed glyphs and draw pixels of them.
This make it easier to implement other rendering backend, and allows switching rendering backend at runtime.
The original code of glyph rendering for swash is moved into Draw.
And add draw_with method to Buffer and Edit interfaces to draw with glyph rendering backend that implemented Draw trait. The original glyph drawing part using swash in buffer and editor is also migrated to using Draw.
I am thinking we could also deprecate swash specific
draw
methods in Buffer and Edit to usedraw_with
instead. Or just modify the interface ofdraw
.