Skip to content

Merge pull request #191 from dovreshef/fix_rtl_issue_190 #414

Merge pull request #191 from dovreshef/fix_rtl_issue_190

Merge pull request #191 from dovreshef/fix_rtl_issue_190 #414

Triggered via push September 23, 2023 17:39
Status Success
Total duration 5m 34s
Artifacts

rust.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

12 warnings
docs for function returning `Result` missing `# Errors` section: src/edit/vi.rs#L460
warning: docs for function returning `Result` missing `# Errors` section --> src/edit/vi.rs:460:5 | 460 | / pub fn load_text<P: AsRef<std::path::Path>>( 461 | | &mut self, 462 | | path: P, 463 | | attrs: crate::Attrs, 464 | | ) -> std::io::Result<()> { | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
docs for function returning `Result` missing `# Errors` section: src/edit/vi.rs#L35
warning: docs for function returning `Result` missing `# Errors` section --> src/edit/vi.rs:35:5 | 35 | / pub fn load_text<P: AsRef<std::path::Path>>( 36 | | &mut self, 37 | | font_system: &mut FontSystem, 38 | | path: P, 39 | | attrs: crate::Attrs, 40 | | ) -> std::io::Result<()> { | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc note: the lint level is defined here --> src/lib.rs:86:9 | 86 | #![warn(clippy::missing_errors_doc)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^
docs for function which may panic missing `# Panics` section: src/buffer_line.rs#L218
warning: docs for function which may panic missing `# Panics` section --> src/buffer_line.rs:218:5 | 218 | / pub fn layout_in_buffer( 219 | | &mut self, 220 | | scratch: &mut ShapeBuffer, 221 | | font_system: &mut FontSystem, ... | 224 | | wrap: Wrap, 225 | | ) -> &[LayoutLine] { | |______________________^ | note: first possible panic found here --> src/buffer_line.rs:234:9 | 234 | self.layout_opt.as_ref().expect("layout not found") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
docs for function which may panic missing `# Panics` section: src/buffer_line.rs#L200
warning: docs for function which may panic missing `# Panics` section --> src/buffer_line.rs:200:5 | 200 | / pub fn layout( 201 | | &mut self, 202 | | font_system: &mut FontSystem, 203 | | font_size: f32, 204 | | width: f32, 205 | | wrap: Wrap, 206 | | ) -> &[LayoutLine] { | |______________________^ | note: first possible panic found here --> src/buffer_line.rs:214:9 | 214 | self.layout_opt.as_ref().expect("layout not found") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
docs for function which may panic missing `# Panics` section: src/buffer_line.rs#L176
warning: docs for function which may panic missing `# Panics` section --> src/buffer_line.rs:176:5 | 176 | / pub fn shape_in_buffer( 177 | | &mut self, 178 | | scratch: &mut ShapeBuffer, 179 | | font_system: &mut FontSystem, 180 | | ) -> &ShapeLine { | |___________________^ | note: first possible panic found here --> src/buffer_line.rs:191:9 | 191 | self.shape_opt.as_ref().expect("shape not found") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
docs for function which may panic missing `# Panics` section: src/buffer.rs#L494
warning: docs for function which may panic missing `# Panics` section --> src/buffer.rs:494:5 | 494 | pub fn layout_cursor(&self, cursor: &Cursor) -> LayoutCursor { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first possible panic found here --> src/buffer.rs:498:22 | 498 | let layout = line.layout_opt().as_ref().expect("layout not found"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
docs for function which may panic missing `# Panics` section: src/buffer.rs#L137
warning: docs for function which may panic missing `# Panics` section --> src/buffer.rs:137:5 | 137 | pub fn highlight(&self, cursor_start: Cursor, cursor_end: Cursor) -> Option<(f32, f32)> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first possible panic found here --> src/buffer.rs:159:25 | 159 | let x_end = x_end.expect("end of cursor not found"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
this `impl` can be derived: src/buffer.rs#L89
warning: this `impl` can be derived --> src/buffer.rs:89:1 | 89 | / impl Default for Affinity { 90 | | fn default() -> Self { 91 | | Affinity::Before 92 | | } 93 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it... | 58 + #[derive(Default)] 59 | pub enum Affinity { | help: ...and mark the default variant | 59 ~ #[default] 60 ~ Before, |
docs for function which may panic missing `# Panics` section: src/attrs.rs#L272
warning: docs for function which may panic missing `# Panics` section --> src/attrs.rs:272:5 | 272 | pub fn split_off(&mut self, index: usize) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first possible panic found here --> src/attrs.rs:288:34 | 288 | let (range, attrs) = self | __________________________________^ 289 | | .spans 290 | | .get_key_value(&key.start) 291 | | .map(|v| (v.0.clone(), v.1.clone())) 292 | | .expect("attrs span not found"); | |_______________________________________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc note: the lint level is defined here --> src/lib.rs:88:9 | 88 | #![warn(clippy::missing_panics_doc)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^
this `else { if .. }` block can be collapsed: src/shape.rs#L1254
warning: this `else { if .. }` block can be collapsed --> src/shape.rs:1254:24 | 1254 | } else { | ________________________^ 1255 | | if self.rtl { 1256 | | start_x - x 1257 | | } else { 1258 | | x 1259 | | } 1260 | | }, | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `#[warn(clippy::collapsible_else_if)]` on by default help: collapse nested if block | 1254 ~ } else if self.rtl { 1255 + start_x - x 1256 + } else { 1257 + x 1258 ~ }, |
lint `clippy::integer_arithmetic` has been renamed to `clippy::arithmetic_side_effects`: src/lib.rs#L67
warning: lint `clippy::integer_arithmetic` has been renamed to `clippy::arithmetic_side_effects` --> src/lib.rs:67:10 | 67 | #![allow(clippy::integer_arithmetic)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::arithmetic_side_effects` | = note: `#[warn(renamed_and_removed_lints)]` on by default
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/