Correctly shutdown all scheduler threads #4549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, it was possible to not shutdown all scheduler threads. ponyint_thread_join on non-Windows systems calls pthread_join. pthread_join can fail and that failure needs to be handled. In our case here, given that ponyint_thread_join returns a boolean, the response to an error is to try again. If we encounter a non-recoverable error, this new strategy should result in a hang rather than undefined behavior. If we have hangs that we trace to this changed functionality, we look at more robust error handling and changing the interface from ponyint_thread_join.
ponylang-main
added
the
discuss during sync
jemc
approved these changes
Nov 26, 2024
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, it was possible to not shutdown all scheduler threads. ponyint_thread_join on non-Windows systems calls pthread_join. pthread_join can fail and that failure needs to be handled. In our case here, given that ponyint_thread_join returns a boolean, the response to an error is to try again.
If we encounter a non-recoverable error, this new strategy should result in a hang rather than undefined behavior. If we have hangs that we trace to this changed functionality, we look at more robust error handling and changing the interface from ponyint_thread_join.