Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger GC for actors when they tell the cycle detector they're blocked #3278

Merged
merged 8 commits into from
Aug 8, 2022
Merged

Trigger GC for actors when they tell the cycle detector they're blocked #3278

merged 8 commits into from
Aug 8, 2022

Commits on Aug 7, 2022

  1. Trigger GC for actors when they tell the cycle detector they're blocked 

    Prior to this commit, if an actor blocked, it did not run GC to free
any memory it no longer needed. This would result in blocked actors
holding on to (potentially lots of) memory unnecessarily.

This commit causes GC to be triggered when the cycle detector asks
an actor if it is blocked and the actor responds telling the cycle
detector that it is blocked and also when the actor initially tells
the cycle detector that it is blocked. This should result in memory
being held by blocked actors to be freed more quickly even if the
cycle detector doesn't end up detecting a cycle and reaping the
actors.
    @dipinhora
    dipinhora committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    808f797 View commit details
    Browse the repository at this point in the history

  2. Update comment based on review feedback 

    Co-authored-by: Sean T Allen <[email protected]>
    @dipinhora @SeanTAllen
    dipinhora and SeanTAllen committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    00ff101 View commit details
    Browse the repository at this point in the history

  3. Revert check for heap.used == 0 in triggergc 

    Review pointed out that this is unnecessary because the same logic
is already accounted for in `ponyint_heap_startgc` already.
    @dipinhora
    dipinhora committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    ddd289d View commit details
    Browse the repository at this point in the history

  4. Move assertion up a few lines.

    @dipinhora
    dipinhora committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    48aac86 View commit details
    Browse the repository at this point in the history

  5. update comment based on review

    @dipinhora
    dipinhora committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    cee8dfd View commit details
    Browse the repository at this point in the history

  6. Make sure to GC *before* sending ACTORMSG_BLOCK to CD

    @dipinhora
    dipinhora committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    eb4bb47 View commit details
    Browse the repository at this point in the history

  7. Relocate try_gc

    @dipinhora
    dipinhora committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    78c06af View commit details
    Browse the repository at this point in the history

  8. force CI

    @dipinhora
    dipinhora committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    88724b4 View commit details
    Browse the repository at this point in the history