Fiber refactorings #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgprudhomme
commented
Aug 5, 2024
| private final ExecutorService highPriorityPool = | ||
| Executors.newCachedThreadPool(new HighPriorityThreadFactory()); | ||
| Executors.newThreadPerTaskExecutor(new HighPriorityThreadFactory()); |
There was a problem hiding this comment.
Hits these JMH benchmarks
bgprudhomme
commented
Aug 14, 2024
| @@ -31,9 +31,7 @@ private String getThreadID() { | |||
| abstract String getThreadNamePrefix(); | |||
|
|
|||
| public Thread newThread(Runnable runnable) { | |||
| Thread thread = new Thread(runnable); | |||
| thread.setName(getThreadNamePrefix() + "-" + getThreadID()); | |||
| thread.setDaemon(true); | |||
There was a problem hiding this comment.
Virtual threads are always daemon threads
bgprudhomme
commented
Aug 14, 2024
| @@ -66,11 +64,11 @@ String getThreadNamePrefix() { | |||
|
|
|||
| private boolean isShutdown = false; | |||
| private final ExecutorService lowPriorityPool = | |||
| Executors.newCachedThreadPool(new LowPriorityThreadFactory()); | |||
| Executors.newThreadPerTaskExecutor(new LowPriorityThreadFactory()); | |||
There was a problem hiding this comment.
The API says newVirtualThreadPerTaskExecutor is equivalent to newThreadPerTaskExecutor with a factory producing virtual threads
bgprudhomme
commented
Aug 14, 2024
| @@ -31,9 +31,7 @@ private String getThreadID() { | |||
| abstract String getThreadNamePrefix(); | |||
|
|
|||
| public Thread newThread(Runnable runnable) { | |||
| Thread thread = new Thread(runnable); | |||
There was a problem hiding this comment.
This is the new Thread(...) call inside the newThread(...) method used by the _PriorityThreadFactory classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.