Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift 4 support #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Swift 4 support #24

wants to merge 2 commits into from

Conversation

PoeticPete
Copy link

Hello! Here's a quick change that makes it Swift 4 compatible. Would it be possible to create a new Swift 4 branch?

@robertoferraz
Copy link

Hey guys, could you take a look on this branch? It would be nice to have it updated to Swift 4

JoniVR
JoniVR approved these changes Oct 9, 2017
View reviewed changes
Copy link

@JoniVR JoniVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on iOS 11.0, working perfectly.
Only still has the yellow warnings indicating that the "Swift 3 objc inference" setting in build settings still needs to be set to "Default" which is an easy change.

warnings

detail

@PoeticPete
Copy link
Author

Fixed!

@JoniVR JoniVR mentioned this pull request Nov 13, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoniVR JoniVR JoniVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PoeticPete @robertoferraz @JoniVR