Add optional/default animation bool to provide non-animated index sel… #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Fantastic library! I recently used this segment control in a small project. I had a use case where I wanted to refresh a UIView that contained the TwicketSegmentedControl and default it to the current selection. However, because the move(to index: Int) was always animated, it became obvious the view was being refreshed.
I thought it may be beneficial to have the ability to move the selectedSegmentIndex without animation. The new optional/defaulting animation parameter on the move function should not affect any existing calls or break any code from what it appears.
Cheers!
Matt