Add more integrations tests to People chains #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Tests look good! 👍
Please add the same to https://github.com/paritytech/polkadot-sdk/tree/master/cumulus/parachains/integration-tests/emulated/tests/people to keep the covered functionality in sync.
|
@acatangiu certainly. Thanks for the review! |
Why? |
rockbmb
force-pushed
the
pallet-identity-root-extrinsics
branch
from
fec09e0
to
a780f51
Compare
|
Review required! Latest push from author must always be reviewed |
1 similar comment
|
Review required! Latest push from author must always be reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/open-web3-stack/polkadot-ecosystem-tests relies on chopsticks to create E2E tests using periodically (roughly daily) obtained runtimes from production relay chains/system parachains.
In particular, open-web3-stack/polkadot-ecosystem-tests#63 does this for the People chains.
In writing those tests, I was unable to use XCM to test
pallet_identity::{kill_identity/add_username_authority/remove_username_authority}.I wrote this PR to replicate those tests at this layer, whose passing status falsify the hypothesis that there may have been an issue with the runtimes, and confirm that it was a problem with the way I wrote those tests.