Download a screenful of history instead of fixed 10 messages #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not perfect because messages may span multiple lines and in some cases less messages are returned than "limit". But it's better guess than magic number of 10, though.
poljar
requested changes
Nov 12, 2019
| uuid, request = self.client.room_messages( | ||
| room_id, | ||
| room_buffer.prev_batch, | ||
| limit=10) |
There was a problem hiding this comment.
Right this should have been max_initial_sync_events instead. We should use this instead and make your way a configurable option. Pretty sure not everyone wants their chat window filled.
|
Also, this will download (screen size) messages, including filtered ones; so if there are many filtered messages, the number of added messages might still be less than a screen (it can be zero too) |
|
Is there a way to download all of the availible chat history? Or some arbitray larger amount of history? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening the chat window for the first time, load as many messages as there are chat window rows.
This is not perfect because messages may span multiple lines and in
some cases less messages are returned than "limit". But it's better
guess than magic number of 10, though.