Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta fix (addresses issue #290) #395

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

jmumford
Copy link

This addresses issue

The 'meta' option for SecondLevelModel will now run a pymare based estimators.WeightedLeastSquares() analysis.

I have tested on nifti and cifti data, the 'meta' and 'glm' options, for design matrices using only an intercept or with a regressor that requires an events.tsv file. Most tests focused on single subject analyses, averaging data within-subject across runs. My addition to setup.cfg to install pymare was not tested and should be checked.

Pull request is ready for review.

setup.cfg Outdated Show resolved Hide resolved
@pep8speaks
Copy link

Hello @jmumford, Thank you for updating!

Line 346:1: W293 blank line contains whitespace
Line 371:1: W293 blank line contains whitespace
Line 434:22: W291 trailing whitespace

Line 14:1: W293 blank line contains whitespace
Line 16:1: E303 too many blank lines (3)

To test for issues locally, pip install flake8 and then run flake8 fitlins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants