deps: update arrow and parquet #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asubiotto
force-pushed
the
alfonso-deps
branch
from
c59e451 to
05a3ebb
Compare
|
Currently working on workflow changes in #601 to get this to pass |
This is only used in tests, but not updating this causes future commits to fail to build.
This includes lz4 buffer pooling fixes and removing calls to schema.Fields which improves allocations.
This pulls in pooling for comparison buffers in parquet, which reduces allocations.
This includes a change to buffer dictionary pages which is still pending review.
asubiotto
force-pushed
the
alfonso-deps
branch
from
05a3ebb to
f4948d8
Compare
|
OK, this PR should now pass. |
brancz
approved these changes
Nov 29, 2023
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| ) | ||
|
|
||
| // Remove when the following PRs are available in a release. |
There was a problem hiding this comment.
Why a release? We can just use a main version, no? (both of them are now merged)
There was a problem hiding this comment.
We can, but I think it's better practice to use releases as we currently do and not sure it makes sense to switch to start using main. This tip is just v14 with the two cherry-picked changes. Happy to change though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates arrow and parquet to custom tips with all the allocation improvements. Parquet is pointed to a custom tip given the change to pool dictionary pages is still pending review. I'm happy to just point it to latest and wait as well.