Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Ensure explicit values given to column_widths override autofit in write_excel #20893

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

arnabanimesh
Copy link
Contributor

No description provided.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.73%. Comparing base (e98e09b) to head (335e7fb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/dataframe/frame.py 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20893      +/-   ##
==========================================
- Coverage   79.73%   79.73%   -0.01%     
==========================================
  Files        1566     1566              
  Lines      222681   222681              
  Branches     2572     2572              
==========================================
- Hits       177551   177549       -2     
- Misses      44538    44540       +2     
  Partials      592      592              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-beedie
Copy link
Collaborator

Makes sense; good catch 👍

@alexander-beedie alexander-beedie changed the title fix(python): Make column_widths override autofit in write_excel function fix(python): Ensure explicit values given to column_widths override autofit in write_excel Jan 24, 2025
@alexander-beedie alexander-beedie added the A-io-spreadsheet Area: reading/writing Excel/ODS files label Jan 24, 2025
@alexander-beedie alexander-beedie merged commit 884feeb into pola-rs:main Jan 24, 2025
17 checks passed
@arnabanimesh arnabanimesh deleted the patch-2 branch January 25, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-io-spreadsheet Area: reading/writing Excel/ODS files fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants