Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Improve internal string → date casts in read_excel #20845

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Jan 22, 2025

Closes #20832.

  • Ensures that Date casts indicated by schema_overrides succeed by having fastexcel read them as datetimes before we apply the override casts (so that date strings with trailing " 00:00:00" time components do not fail).
  • Note that we do not generate the other warnings mentioned in the issue - that is an upstream issue, so we can close it out here.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.63%. Comparing base (9c1637c) to head (abd598f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20845      +/-   ##
==========================================
- Coverage   79.63%   79.63%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      223146   223146              
  Branches     2546     2546              
==========================================
- Hits       177711   177709       -2     
- Misses      44851    44853       +2     
  Partials      584      584              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_excel warnings and errors (typing issues)
1 participant