fix(python): Selectors should raise on +
between themselves
#20825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20821.
Selectors as sets
Selectors act as sets and support the standard set ops:
https://docs.pola.rs/api/python/stable/reference/selectors.html#set-operations
Standard set behaviour
However... sets do not support the
+
operator between themselves.We are inadvertently passing-through
+
between selectors to Expr, leading to very peculiar (and unintended) results or errors in cases where the caller meant to use|
or&
instead. This PR fixes that (while retaining support for broadcasting).Example
Use of
+
between selectors now raises......but continues to broadcast: