feat: Add CSV sink for the new streaming engine #20804
Merged
+183
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
orlp and
c-peters
as code owners
github-actions
bot
added
enhancement
coastalwhite
commented
Jan 20, 2025
| @@ -221,15 +221,20 @@ fn to_graph_rec<'a>( | |||
| nodes::io_sinks::ipc::IpcSinkNode::new(input_schema, path, ipc_writer_options)?, | |||
| [(input_key, input.port)], | |||
| ), | |||
| #[cfg(feature = "ipc")] | |||
There was a problem hiding this comment.
drive-by: this was not correct
ritchie46
reviewed
Jan 20, 2025
| .with_float_precision(options.serialize_options.float_precision) | ||
| .with_null_value(options.serialize_options.null.clone()) | ||
| .with_quote_style(options.serialize_options.quote_style) | ||
| .n_threads(1) // Disable rayon parallelism |
ritchie46
reviewed
Jan 20, 2025
|
|
||
| let mut buffer = Vec::with_capacity(allocation_size); | ||
| let mut writer = CsvWriter::new(&mut buffer) | ||
| .include_bom(false) // Handled once in the IO task. |
There was a problem hiding this comment.
Maybe we can hoist the writer out of the while loop?
There was a problem hiding this comment.
I don't think it matters much since the CsvWriter creation is cheap, and we cannot reuse the allocation anyway because it needs to be passed to the IO task.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20804 +/- ##
==========================================
- Coverage 79.77% 79.75% -0.03%
==========================================
Files 1561 1562 +1
Lines 222029 222397 +368
Branches 2533 2533
==========================================
+ Hits 177132 177369 +237
- Misses 44313 44444 +131
Partials 584 584 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @orlp.