feat(python): Account for SurrealDB Python API updates (handle both SurrealDB
and AsyncSurrealDB
classes) in read_database
#20799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SurrealDB Python API has been updated (at the end of last year) in conjunction with their latest major release, splitting out
SurrealDB
andAsyncSurrealDB
classes.This PR updates our
SurrealDBCursorProxy
shim so that it can handle both the sync and async variants of the client object.Tested (thoroughly!) locally with the sync and async clients (executing the async loop under both
asyncio
anduvloop
).Example
Synchronous (
SurrealDB
):Aynchronous (
AsyncSurrealDB
):