Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore file cache allocation error if fallocate() is not permitted #20796

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jan 20, 2025

Update to automatically ignore the error without needing the environment variable to be set if the system does not permit fallocate().

ref #17946

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 79.77%. Comparing base (3696e53) to head (26b5d1a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/file_cache/entry.rs 31.25% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20796      +/-   ##
==========================================
- Coverage   79.78%   79.77%   -0.01%     
==========================================
  Files        1561     1561              
  Lines      222015   222019       +4     
  Branches     2533     2533              
==========================================
- Hits       177135   177125      -10     
- Misses      44296    44310      +14     
  Partials      584      584              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review January 20, 2025 07:51
@ritchie46 ritchie46 merged commit a0b1037 into pola-rs:main Jan 20, 2025
23 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants