Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Drop nest-asyncio in favor of custom logic #20793

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Conversation

stinodego
Copy link
Contributor

In Polars Cloud we implemented this nested async functionality without a dependency. Figured we should do the same for the open source repo.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jan 19, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.77%. Comparing base (87b03aa) to head (80805f5).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/io/database/_utils.py 80.95% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20793      +/-   ##
==========================================
- Coverage   79.78%   79.77%   -0.01%     
==========================================
  Files        1561     1561              
  Lines      222001   222014      +13     
  Branches     2531     2533       +2     
==========================================
+ Hits       177117   177121       +4     
- Misses      44302    44309       +7     
- Partials      582      584       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as draft January 19, 2025 12:14
@stinodego stinodego marked this pull request as ready for review January 19, 2025 12:19
@ritchie46
Copy link
Member

Nice one!

@ritchie46 ritchie46 merged commit 3696e53 into main Jan 19, 2025
15 checks passed
@ritchie46 ritchie46 deleted the nest-asyncio branch January 19, 2025 19:50
@c-peters c-peters added the accepted Ready for implementation label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants