Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix allow_invalid_certificates being ignored in storage_options #20744

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jan 16, 2025

Fixes the general case of all ClientConfigKeys1 set in storage_options being ignored - we have a set of defaults get_client_options() that needs to be set at the beginning rather than after the config has been parsed to avoid overwriting them.

Should fix #20727, but I can't verify this locally.

Footnotes

  1. https://docs.rs/object_store/latest/object_store/enum.ClientConfigKey.html

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 16, 2025
@nameexhaustion nameexhaustion marked this pull request as ready for review January 16, 2025 13:11
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.71%. Comparing base (233b396) to head (604c4d5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/cloud/options.rs 76.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20744      +/-   ##
==========================================
- Coverage   79.72%   79.71%   -0.01%     
==========================================
  Files        1561     1561              
  Lines      221908   221909       +1     
  Branches     2530     2530              
==========================================
- Hits       176915   176905      -10     
- Misses      44411    44422      +11     
  Partials      582      582              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit ce9ad17 into pola-rs:main Jan 16, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On-prem S3 can't be accessed with Polars, but fine with delta-rs
2 participants