Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix unique(maintain_order=True) raising InvalidOperationError for null array #20737

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: Fix unique(maintain_order=True) raising InvalidOperationError for null array #20737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/polars-core/src/series/implementations/null.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,12 @@ impl SeriesTrait for NullChunked {
Ok(n)
}

#[cfg(feature = "algorithm_group_by")]
fn arg_unique(&self) -> PolarsResult<IdxCa> {
let idxs: Vec<IdxSize> = (0..self.n_unique().unwrap() as IdxSize).collect();
Ok(IdxCa::new(self.name().clone(), idxs))
}

fn new_from_index(&self, _index: usize, length: usize) -> Series {
NullChunked::new(self.name.clone(), length).into_series()
}
Expand Down
9 changes: 5 additions & 4 deletions py-polars/tests/unit/operations/unique/test_unique.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,15 +117,16 @@ def test_sorted_unique_dates() -> None:
).to_dict(as_series=False) == {"dt": [date(2015, 6, 23), date(2015, 6, 24)]}


def test_unique_null() -> None:
@pytest.mark.parametrize("maintain_order", [True, False])
def test_unique_null(maintain_order: bool) -> None:
s0 = pl.Series([])
assert_series_equal(s0.unique(), s0)
assert_series_equal(s0.unique(maintain_order=maintain_order), s0)

s1 = pl.Series([None])
assert_series_equal(s1.unique(), s1)
assert_series_equal(s1.unique(maintain_order=maintain_order), s1)

s2 = pl.Series([None, None])
assert_series_equal(s2.unique(), s1)
assert_series_equal(s2.unique(maintain_order=maintain_order), s1)


@pytest.mark.parametrize(
Expand Down
Loading