-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix incorrect top-k by sorted column, fix head()
returning extra rows
#20722
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20722 +/- ##
==========================================
- Coverage 79.92% 79.84% -0.08%
==========================================
Files 1559 1560 +1
Lines 221181 221396 +215
Branches 2530 2530
==========================================
+ Hits 176774 176779 +5
- Misses 43825 44035 +210
Partials 582 582 ☔ View full report in Codecov by Sentry. |
if let Some((0, k)) = slice { | ||
if k < self.len() { | ||
let desc = if sort_options.descending.len() == 1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue was this desc
parameter, I've removed it
head()
returning extra rows
Fixes #20719
Fixes #20712
Fixes #20715
Changelog
descending
parameter fromSortOptions.limit
- it is duplicated with the top-leveldescending
configtop_k
on sorted data containing duplicates returned incorrect values (the duplicated rows were ignored):