test: Add tests for various open issues #20720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20720 +/- ##
==========================================
+ Coverage 79.92% 79.93% +0.01%
==========================================
Files 1559 1559
Lines 221170 221178 +8
Branches 2530 2530
==========================================
+ Hits 176764 176796 +32
+ Misses 43824 43800 -24
Partials 582 582 ☔ View full report in Codecov by Sentry. |
|
Wow, good find. Proper detective skills. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for the following open issues that are already fixed on the main branch:
closes #12957
closes #14881
closes #14992
closes #15523
closes #15583
The following open issues also appear to be fixed on the main branch. This PR does not add any tests for these issues as it appears tests have already been added that cover the originally reported issue. I've noted the tests below and commented on the individual issues. These can either be closed by merging this PR or by closing each issue directly:
closes #12521 -> test_list.py::test_fill_null_empty_list
closes #15151 -> test_decimal.py::test_decimal_round
closes #15130 -> test_parquet.py::test_parquet_array_dtype_nulls
closes #16692 -> test_parquet.py::test_nested_decimal
closes #17013 -> test_unpivot.py::test_unpivot_categorical_global