-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Expand plotting docs #19719
docs: Expand plotting docs #19719
Conversation
1d7f3c3
to
27b846d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19719 +/- ##
==========================================
- Coverage 79.63% 79.62% -0.01%
==========================================
Files 1564 1564
Lines 217478 217478
Branches 2473 2473
==========================================
- Hits 173181 173177 -4
- Misses 43728 43732 +4
Partials 569 569 ☔ View full report in Codecov by Sentry. |
@rodrigogiraoserrao fancy taking a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have a comment: it feels like there was something missing in a docstring.
If I misinterpreted it, just let me know and I'll change my review status.
Sorry I missed the PR!
py-polars/polars/dataframe/frame.py
Outdated
- Set the x-axis title by passing ``x=alt.X('length', title='Length')`` instead | ||
of ``x='length'``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This last bullet point feels incomplete:
Set the x-axis title by passing x=alt.X(...)
instead of x=...
... where? Where do I pass it?
(Also, you have the same list in visualization.md
and in series.py
but this fourth item is only present in this list. It looks like all three lists should look the same but I'm not sure, so I'm just flagging this here in case you missed it.)
This documentation is exactly what I needed! I noticed that some of the examples of the different libraries have the x/y axes swapped; might be nice to make that consistent. |
good points, thanks both for your reviews! have addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :D
awesome, thanks! |
In summary, this:
screenshots of how it looks (current user guide for comparison https://docs.pola.rs/user-guide/misc/visualization/)