depr(python): Deprecate tree_format parameter for LazyFrame.explain in favor of format
#16486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n` in favor of `format`
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
stinodego
changed the title
LazyFrame.explain in favor of formattree_format parameter for LazyFrame.explain in favor of format
github-actions
bot
added
deprecation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16486 +/- ##
==========================================
+ Coverage 81.42% 81.49% +0.07%
==========================================
Files 1409 1409
Lines 184924 184929 +5
Branches 2978 2980 +2
==========================================
+ Hits 150577 150712 +135
+ Misses 33826 33696 -130
Partials 521 521 ☔ View full report in Codecov by Sentry. |
alexander-beedie
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
formatparameter is more appropriate here, to facilitate potential other formats like proposed here:#12075
Also added some tests because there were 0 tests for the tree format parameter.