feat(python): Improve string → temporal parsing in read_excel and read_ods
#20845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
c-peters,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
enhancement
alexander-beedie
force-pushed
the
misc-excel-improvements
branch
from
c23adc9 to
abd598f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20845 +/- ##
==========================================
- Coverage 79.75% 79.74% -0.01%
==========================================
Files 1566 1566
Lines 222536 222558 +22
Branches 2562 2572 +10
==========================================
+ Hits 177475 177480 +5
- Misses 44472 44486 +14
- Partials 589 592 +3 ☔ View full report in Codecov by Sentry. |
alexander-beedie
force-pushed
the
misc-excel-improvements
branch
from
abd598f to
ab2248b
Compare
alexander-beedie
changed the title
read_excelread_excel
alexander-beedie
changed the title
read_excelread_excel
alexander-beedie
changed the title
read_excelread_excel and read_ods
alexander-beedie
added
the
A-io-spreadsheet
ritchie46
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20832.
Datetime,Date, andTimedata from spreadsheets.Note that we do not generate the other warnings mentioned - that is an upstream issue, and has been raised there.