solve several smaller issues

pola-rs · Jan 15, 2025 · 332161a · 332161a
1 parent 14e839f
commit 332161a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/crates/polars-arrow/src/array/binview/mutable.rs b/crates/polars-arrow/src/array/binview/mutable.rs
@@ -598,7 +598,7 @@ impl<T: ViewType + ?Sized> MutableBinaryViewArray<T> {
                 bm.extend_constant(slf_len, true);
                 bm.extend_from_bitmap(other);
                 *v = Some(bm);
-            }
+            },
             (Some(slf), Some(other)) => slf.extend_from_bitmap(other),
         }
 

diff --git a/crates/polars-io/src/predicates.rs b/crates/polars-io/src/predicates.rs
@@ -145,7 +145,7 @@ fn cast_to_parquet_scalar(scalar: Scalar) -> Option<ParquetScalar> {
         A::Int16(v) => P::Int16(v),
         A::Int32(v) => P::Int32(v),
         A::Int64(v) => P::Int64(v),
-            
+
         #[cfg(feature = "dtype-time")]
         A::Date(v) => P::Int32(v),
         #[cfg(feature = "dtype-datetime")]

diff --git a/crates/polars-parquet/src/arrow/read/deserialize/null.rs b/crates/polars-parquet/src/arrow/read/deserialize/null.rs
@@ -105,7 +105,12 @@ impl utils::Decoder for NullDecoder {
             todo!()
         }
 
-        decoded.length += Filter::opt_num_rows(&filter, state.translation.num_rows);
+        let num_rows = match filter {
+            Some(f) => f.num_rows(0),
+            None => state.translation.num_rows,
+        };
+        decoded.length += num_rows;
+
         Ok(())
     }
 }
diff --git a/crates/polars-parquet/src/arrow/read/deserialize/primitive/plain/mod.rs b/crates/polars-parquet/src/arrow/read/deserialize/primitive/plain/mod.rs
@@ -70,6 +70,7 @@ pub fn decode<P: ParquetNativeType, T: NativeType, D: DecoderFunction<P, T>>(
                 polars_compute::filter::filter_with_bitmap(&array, &intermediate_pred_true_mask);
             let array = array.as_any().downcast_ref::<PrimitiveArray<T>>().unwrap();
 
+            pred_true_mask.extend_from_bitmap(&intermediate_pred_true_mask);
             target.extend(array.values().iter().copied());
             if is_optional {
                 match array.validity() {