Add supply indexing #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecuesta
changed the title
jorgecuesta
changed the title
bryanchriswhite
requested changes
Nov 13, 2024
bryanchriswhite
approved these changes
Nov 13, 2024
|
@bryanchriswhite Please refer to the attached images to look how the structure looks at the database and also the same result on the graphql query. I think now this achieve a proper handling of supply for any denomination on the block, which allows further updates on the protocol like IBC transactions without need to modify it.
|
bryanchriswhite
requested changes
Nov 18, 2024
There was a problem hiding this comment.
@jorgecuesta this is looking really good! 🙌
I just had a few suggestions and then we can 🚢.
bryanchriswhite
approved these changes
Nov 18, 2024
|
All the suggestions gone applied @bryanchriswhite now just wait to get the #26 before rebase and merge it. Thanks! |
- Introduce SupplyDenom entity - Introduce Supply entity - Introduce BlockSupply join entity - Update block to relate with BlockSupply - Handle genesis SupplyDenom and Supply
jorgecuesta
force-pushed
the
add-supply
branch
from
683a347 to
82c6276
Compare
jorgecuesta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the Supply entity and updates the block entity.
Issue
This PR addresses improvements required for supply handling and indexing. The updates include:
Type of change
Select one or more:
Sanity Checklist