This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
[CHORE] Add first part of tests for pocket basic client #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue
#16
Description
This PR:
Deferred for followup PR: There will be a future PR to mock out the HTTP responses for
makeRequest
inbasic_client.go
which will allow us to have full coverage on the pocket client. It's been deferred because mocking out fastify for client is not trivialType of change
Please delete option that is not relevant.
Related PRs
List related PRs below