Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

[CHORE] Add first part of tests for pocket basic client #15

Merged
merged 6 commits into from
Dec 18, 2023

Conversation

nodiesBlade
Copy link
Collaborator

@nodiesBlade nodiesBlade commented Dec 18, 2023

Github issue

#16

Description

This PR:

  • seperates generate proof functionality and adds a test for it.
  • adds tests for ed25519 account
  • adds tests for finding a random node from a request
  • add tests for finding a session from a request

Deferred for followup PR: There will be a future PR to mock out the HTTP responses for makeRequest in basic_client.go which will allow us to have full coverage on the pocket client. It's been deferred because mocking out fastify for client is not trivial

Type of change

Please delete option that is not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Related PRs

List related PRs below

branch PR
other_pr link

@nodiesBlade nodiesBlade changed the title Chore/unassigned/relay client tests [CHORE] Add first part of tests for pocket basic client Dec 18, 2023
@nodiesBlade nodiesBlade marked this pull request as ready for review December 18, 2023 09:27
@nodiesBlade nodiesBlade merged commit c7c9372 into main Dec 18, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants