Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache dependencies in withDependencies update closure #287

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

stephencelis
Copy link
Member

Currently we avoid caching to allow issues to be reported during later access, but we can instead just always report issues when a certain criteria is met:

  • We're not already in the dependency values storage (goes to cache)
  • We're not in the process of setting dependency values
  • We're in a "live" context
  • The dependency has no live implementation

@stephencelis stephencelis requested a review from mbrandonw October 9, 2024 22:07
@stephencelis stephencelis merged commit 26b95e1 into main Nov 8, 2024
5 checks passed
@stephencelis stephencelis deleted the cache-test-values branch November 8, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants