Merge pull request #1 from JoaoCruz2001/JoaoCruz2001-patch-1

Fix "The request was already sent" error when getting app metadata (using AppManager)
pnp · Jun 27, 2023 · 539cef2 · 539cef2
2 parents fdb4be4 + c652513
commit 539cef2
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/src/lib/PnP.Framework/ALM/AppManager.cs b/src/lib/PnP.Framework/ALM/AppManager.cs
@@ -919,14 +919,14 @@ private static async Task<AppMetadata> GetAppMetaData(AppCatalogScope scope, Cli
 
             var metadataRequestUrl = $"{context.Web.Url}/_api/web/{(scope == AppCatalogScope.Tenant ? "tenant" : "sitecollection")}appcatalog/AvailableApps/GetById('{id}')";
 
-            using (var metadataRequest = new HttpRequestMessage(HttpMethod.Get, metadataRequestUrl))
+            while (returnValue == null && retryCount < 5)
             {
-                metadataRequest.Headers.Add("accept", "application/json;odata=nometadata");
-
-                await PnPHttpClient.AuthenticateRequestAsync(metadataRequest, context).ConfigureAwait(false);
-
-                while (returnValue == null && retryCount < 5)
+                using (var metadataRequest = new HttpRequestMessage(HttpMethod.Get, metadataRequestUrl))
                 {
+                    metadataRequest.Headers.Add("accept", "application/json;odata=nometadata");
+
+                    await PnPHttpClient.AuthenticateRequestAsync(metadataRequest, context).ConfigureAwait(false);
+
                     // Perform actual post operation
                     HttpResponseMessage metadataResponse = await httpClient.SendAsync(metadataRequest, new System.Threading.CancellationToken());
 
@@ -951,8 +951,8 @@ private static async Task<AppMetadata> GetAppMetaData(AppCatalogScope scope, Cli
                         await Task.Delay(waitTime * 1000); // wait 10 seconds
                     }
                 }
-                return returnValue;
-            }
+            }  
+            return returnValue;
         }
         #endregion
     }