RCT/YJ/Fix 5-34 bug #1590
Merged
RCT/YJ/Fix 5-34 bug #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return {"failing_infiltration_zone_ids": failing_infiltration_zone_ids} | ||
|
|
||
| def rule_check(self, context, calc_vals=None, data=None): | ||
| return len(calc_vals["failing_infiltration_zone_ids"]) == 0 | ||
| return not calc_vals["failing_infiltration_zone_ids"] |
There was a problem hiding this comment.
I simplified this part because empty list is falsy in Python.
weilixu
approved these changes
Dec 30, 2024
JacksonJ-KC
reviewed
Dec 30, 2024
| p_zone_infiltration = p_zone["infiltration"] | ||
| # b_zone could be NONE - add a check. | ||
| b_zone_infiltration = b_zone["infiltration"] | ||
| if b_zone is not None: |
There was a problem hiding this comment.
what is happening if b_zone is None?
There was a problem hiding this comment.
@weilixu @yunjoonjung-PNNL I think the case where a match cannot be made between baseline and proposed zones needs to be handled explicitly as an undetermined case.
There was a problem hiding this comment.
Addressed in PR #1593.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I addressed issue #1586 in this PR. Thanks!