Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update is_space_a_computer_room.md #1397

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

KarenWGard
Copy link
Collaborator

Changed logic to better reflect the definition of a computer room per ASRHAE 90.1:

computer room: a room whose primary function is to house equipment for the processing and storage of electronic data and that has a design electronic data equipment power density exceeding 20 W/ft2 of conditioned floor area.

Changed logic to better reflect the definition of a computer room per ASRHAE 90.1:

computer room: a room whose primary function is to house equipment for the processing
and storage of electronic data and that has a design electronic data equipment power density
exceeding 20 W/ft2 of conditioned floor area.
@yunjoonjung-PNNL
Copy link
Collaborator

@weilixu Would this function be ready to be merged? It blocks developing Rule 12-4 and updating the get_HVAC_systems_primarily_serving_comp_rooms function.

- Set the total_space_misc_Wattage_including_multiplier variable: `total_space_misc_Wattage_including_multiplier = 0`
- For each miscellaneous equipment id in the space: `For misc_p in space_p.miscellaneous_equipment:`
- Check if the energy type is electricity, if not then skip this misc_p: `if misc_p.energy_type = "ELECTRICITY":`
- Check if the energy type is INFORMATION_TECHNOLOGY_EQUIPMENT: `if misc_p.type == "INFORMATION_TECHNOLOGY_EQUIPMENT":`
Copy link
Collaborator

@claperle claperle Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am goign to approve this but just documenting my concern about requiring this to be categorized thereby creating another input that is will need to bee addressed outside of the model; most tools do not classify to this granularity. The majority ruled against me but just wanted to document this.
I understnad both sides though because if the space type is not defined then a kitchen could be classed as a computer room

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To address the concern, I think this should be raised in a general guideline for BEM vendor or included in the test cases so that vendors know how to interpret misc equipment to be applicable to computer rooms.
I expect most of the work is done by the vendors so that modelers can just follow the vendor's workflow to have the correct RPD file generated.

@weilixu weilixu mentioned this pull request Aug 15, 2024
@weilixu weilixu merged commit 7bf4c89 into develop Jan 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants