-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rule22-17.md #1388
base: develop
Are you sure you want to change the base?
Update Rule22-17.md #1388
Conversation
docs/section22/Rule22-17.md
Outdated
|
||
- check if the heat rejection has fan_shaft_power (not sure the exact python command for this): `if heat_rejection.fan_shaft_power: | ||
- check if the heat rejection has fan_motor_nameplate_power (not sure the exact python command for this): `if heat_rejection.fan_motor_nameplate_power: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing `
docs/section22/Rule22-17.md
Outdated
- if the shaft power is not directly entered, we also need to create an additional note to return with the result, describing how the calculation was completed: `addtitional_note_for_no_shaft_power = " *Note: The fan shaft power for " + heat_rejection + " was not given. For this evaluation, the fan shaft power was cacluated using a rule of thumb where fan_shaft_power = fan_motor_nameplate_power * 0.9 * fan_motor_efficiency." | ||
|
||
- calculate fan brake horsepower by multiplying the fan shaft power by 0.00134102 (the conversion from Watts to HP): `fan_BHP = fan_shaft_power * 0.00134102` | ||
- if the motor nameplate power is not directly entered, we also need to create an additional note to return with the result, describing how the calculation was completed: `addtitional_note_for_no_motor_nameplate_power = " *Note: The fan motor nameplate power for " + heat_rejection + " was not given. For this evaluation, the fan motor nameplate power was cacluated using a rule of thumb where fan_motor_nameplate_power = fan_shaft_power * 0.9 * fan_motor_efficiency." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing `
docs/section22/Rule22-17.md
Outdated
- calculate fan brake horsepower by multiplying the fan shaft power by 0.00134102 (the conversion from Watts to HP): `fan_BHP = fan_shaft_power * 0.00134102` | ||
- if the motor nameplate power is not directly entered, we also need to create an additional note to return with the result, describing how the calculation was completed: `addtitional_note_for_no_motor_nameplate_power = " *Note: The fan motor nameplate power for " + heat_rejection + " was not given. For this evaluation, the fan motor nameplate power was cacluated using a rule of thumb where fan_motor_nameplate_power = fan_shaft_power * 0.9 * fan_motor_efficiency." | ||
|
||
- otherwise, if there is no fan motor nameplate power or no fan_shaft power, then we can't calculate at all, set a boolean: could_not_calculate to TRUE: `could_not_calculate = true` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need
else:
could_not_calculate = True
docs/section22/Rule22-17.md
Outdated
|
||
- set fan_shaft_power equal to the heat_rejection.fan_motor_nameplate_power * 0.9 (0.9 is a rule of thumb suggested by Michael Rosenberg in April 2023): `fan_shaft_power = heat_rejection.fan_motor_nameplate_power * 0.9 * heat_rejection.fan_motor_efficiency` | ||
- set fan_motor_nameplate_power equal to the heat_rejection.fan_shaft_power * 0.9 (0.9 is a rule of thumb suggested by Michael Rosenberg in April 2023): `fan_motor_nameplate_power = heat_rejection.fan_shaft_power * 0.9 * heat_rejection.fan_motor_efficiency` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was finding this confusing because at first when I reviewed this I assumed this meant fan motor nameplate hp but when I got to the end realized it means fan motor nameplate power in kW. I suppose that makes sense but I think hp is much more commonly reported on motor nameplates than kW although the baseline is a virtual motor any way so maybe what is commonly reported on motors does not matter then.
To go from fan_shaft_power to motor nameplate power I think this should be *(1/0.9)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, in the schema the note on the right says nameplate hp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, updated the calculation for fan_BHP to be different depending on whether fan_motor_nameplate_power exists
. If fan_motor_nameplate_power
exists, then fan_BHP = fan_motor_nameplate_power
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not following this, why would fan_BHP equal fan_motor_nameplate_power?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KarenWGard I recommend that we discuss these comments before edits are made to avoid multiple iterations resulting from miscommunications.
docs/section22/Rule22-17.md
Outdated
- if the shaft power is not directly entered, we also need to create an additional note to return with the result, describing how the calculation was completed: `addtitional_note_for_no_shaft_power = " *Note: The fan shaft power for " + heat_rejection + " was not given. For this evaluation, the fan shaft power was cacluated using a rule of thumb where fan_shaft_power = fan_motor_nameplate_power * 0.9 * fan_motor_efficiency." | ||
|
||
- calculate fan brake horsepower by multiplying the fan shaft power by 0.00134102 (the conversion from Watts to HP): `fan_BHP = fan_shaft_power * 0.00134102` | ||
- if the motor nameplate power is not directly entered, we also need to create an additional note to return with the result, describing how the calculation was completed: `addtitional_note_for_no_motor_nameplate_power = " *Note: The fan motor nameplate power for " + heat_rejection + " was not given. For this evaluation, the fan motor nameplate power was cacluated using a rule of thumb where fan_motor_nameplate_power = fan_shaft_power * 0.9 * fan_motor_efficiency." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To go from fan_shaft_power to motor nameplate power I think this should be *(1/0.9)
docs/section22/Rule22-17.md
Outdated
|
||
- get the rated water flow rate (assumed to be gpm): `rated_water_flowrate = heat_rejection.rated_water_flowrate` | ||
|
||
- calculate the efficiency in gpm/hp: `heat_rejection_efficiency = rated_water_flowrate / (fan_BHP)` | ||
|
||
**Rule Assertion - HeatRejection:** | ||
|
||
- Case 1: check if the efficiency is greater than the rated efficiency: `if ( ahj_flag AND ( heat_rejection_efficiency > 38.2 )): UNDETERMINED; note = "The project includes a cooling tower. We calculated the cooling tower efficiency to be " + heat_rejection_efficiency + ", which is greater than the required efficiency of 38.2 gpm / hp, resulting in a more stringent baseline. However, it was not possible to verify that the modeling inputs correspond to the rating conditions in Table 6.8.1-7." + addtitional_note_for_no_shaft_power` | ||
- Case 1: the result couldn't be calcualted because fan_motor_nameplate_power and fan_shaft_power were not given: `if could_not_calculate: UNDETERMINED; note = "The project includes a cooling tower. However, we could not calculate the cooling tower efficiency because neither the fan_motor_nameplate_power nor fan_shaft_power were given" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing `
docs/section22/Rule22-17.md
Outdated
|
||
- Case 2: elsif the heat_rejection_efficiency equals 38.2 gpm/hp, PASS, but include note: `if ( heat_rejection_efficiency == 38.2 ): UNDETERMINED; note = "The project includes a cooling tower. We calculated the cooling tower efficiency to be correct at 38.2 gpm / hp. However, it was not possible to verify that the modeling inputs correspond to the rating conditions in Table 6.8.1-7." + addtitional_note_for_no_shaft_power` | ||
- Case 3: elsif the heat_rejection_efficiency equals 38.2 gpm/hp, PASS, but include note: `if ( heat_rejection_efficiency == 38.2 ): UNDETERMINED; note = "The project includes a cooling tower. We calculated the cooling tower efficiency to be correct at 38.2 gpm / hp. However, it was not possible to verify that the modeling inputs correspond to the rating conditions in Table 6.8.1-7." + additional_note_for_motor_nameplate_power` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description says PASS but the outcome is UNDETERMINED.
docs/section22/Rule22-17.md
Outdated
- calculate fan brake horsepower by multiplying the fan shaft power by 0.00134102 (the conversion from Watts to HP): `fan_BHP = fan_shaft_power * 0.00134102` | ||
- if the motor nameplate power is not directly entered, we also need to create an additional note to return with the result, describing how the calculation was completed: `addtitional_note_for_no_motor_nameplate_power = " *Note: The fan motor nameplate power for " + heat_rejection + " was not given. For this evaluation, the fan motor nameplate power was cacluated using a rule of thumb where fan_motor_nameplate_power = fan_shaft_power * 0.9 * fan_motor_efficiency."` | ||
|
||
- calculate fan brake horsepower by multiplying the fan shaft power by 0.00134102 (the conversion from Watts to HP): `fan_BHP = fan_motor_nameplate_power * 0.00134102` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General concept:
Nameplate hp = BHP * LF, we are assuming an LF of 90%
In addition, For purposes of Table 6.8.1-7 and the App G req, cooling tower performance is defined as the water flow rating of the tower at the thermal rating condition listed in Table 6.8.1-7 divided by the fan motor nameplate [horse] power. So the hp in the 38 GPM/hp is nameplate motor hp.
Other thing to keep in mind is that the schema reports fan_motor_nameplate_power in Watts for SI. Need to divide by 0.746 to convert Watts to nameplate HP. If it is reported in HP (IP units) no conversion needed and it is just GPM/fan_motor_nameplate_power.
Motor nameplate hp (IP units) = fan_shaft_power (hp, IP units)/LF with LF = 90% (I don't think we can use this since it is not in 90.1)
Pass and Fail if motor nameplate power is provided. UNDERTERMINED if only shaft power is provided with note explaining the GPM/hp assumign 90% LF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too.
No description provided.