Skip to content

Commit

Permalink
Addressed issue in 19-19 where if the W/CFM would pass if it was belo…
Browse files Browse the repository at this point in the history
…w the expected value. Now it correctly fails for < 0.3 W/CFM as well, but correctly raises the appropiate message from get_fail_msg. 19-19b is for W/CFM > 0.3 and the new 19-19e is for W/CFM < 0.3
  • Loading branch information
gonz102 committed Nov 19, 2024
1 parent abf8f8a commit 1a828ca
Show file tree
Hide file tree
Showing 2 changed files with 160 additions and 29 deletions.
8 changes: 4 additions & 4 deletions rct229/rulesets/ashrae9012019/section19/section19rule19.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,11 +275,11 @@ def get_manual_check_required_msg(self, context, calc_vals=None, data=None):
more_than_one_supply_fan_b = calc_vals["more_than_one_supply_fan_b"]

if more_than_one_supply_fan_b:
UNDERMINED_MSG = f"{hvac_id_b} has more than one supply fan associated with the HVAC system in the baseline and therefore this check could not be conducted for this HVAC sytem. Conduct manual check for compliance with G3.1.2.9."
UNDETERMINED_MSG = f"{hvac_id_b} has more than one supply fan associated with the HVAC system in the baseline and therefore this check could not be conducted for this HVAC sytem. Conduct manual check for compliance with G3.1.2.9."
else:
UNDERMINED_MSG = f"{hvac_id_b} has zone(s) with non-mechanical cooling in the proposed design, conduct a manual check that the baseline building design includes a fan power allowance of <insert IP or SI version as applicable Pfan = CFMnmc × 0.054, where, CFMnmc = the baseline non-mechanical cooling fan airflow, cfm for the non-mechanical cooling fan in additional to the 0.3 W/CFM allowance for the HVAC system>."
UNDETERMINED_MSG = f"{hvac_id_b} has zone(s) with non-mechanical cooling in the proposed design, conduct a manual check that the baseline building design includes a fan power allowance of <insert IP or SI version as applicable Pfan = CFMnmc × 0.054, where, CFMnmc = the baseline non-mechanical cooling fan airflow, cfm for the non-mechanical cooling fan in additional to the 0.3 W/CFM allowance for the HVAC system>."

return UNDERMINED_MSG
return UNDETERMINED_MSG

def rule_check(self, context, calc_vals=None, data=None):
zones_served_by_hvac_has_non_mech_cooling_bool_p = calc_vals[
Expand All @@ -297,7 +297,7 @@ def rule_check(self, context, calc_vals=None, data=None):
fan_power_per_flow_b,
REQ_FAN_POWER_FLOW_RATIO,
)
) or (fan_power_per_flow_b < REQ_FAN_POWER_FLOW_RATIO)
)

def is_tolerance_fail(self, context, calc_vals=None, data=None):
zones_served_by_hvac_has_non_mech_cooling_bool_p = calc_vals[
Expand Down
Loading

0 comments on commit 1a828ca

Please sign in to comment.