Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of HiOp option names #162

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cnpetra
Copy link

@cnpetra cnpetra commented Jan 6, 2025

Merge request type

  • New feature
  • Resolves bug
  • Documentation
  • Other

Relates to

  • OPFLOW
  • SOPFLOW
  • SCOPFLOW
  • TCOPFLOW
  • CMake build system
  • Spack configuration
  • Manual
  • Web docs
  • Other

This MR updates

  • Header files
  • Source code
  • CMake build system
  • Spack configuration
  • Web docs
  • Manual
  • Other

Summary

ExaGO was using incorrect HiOp option names, causing HiOp to ignore them and use different option values than those intended by ExaGO. This PR updates the names of these options.

Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense. My concern is that almost all CI tests fail but it doesn't seem those failures are caused by changes in this PR.

@cnpetra
Copy link
Author

cnpetra commented Jan 9, 2025

yes, seems CI test fails are system or related to Github ExaGO configurations...

I see

remote: HTTP Basic: Access denied. The provided password or token is incorrect or your account has 2FA enabled and you must use a personal access token instead of a password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants