Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicholson/frontier worldshared cpe23.12 #151

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

nkoukpaizan
Copy link
Collaborator

@nkoukpaizan nkoukpaizan commented Jul 29, 2024

Merge request type

  • New feature
  • Resolves bug
  • Documentation
  • Other

Relates to

  • OPFLOW
  • SOPFLOW
  • SCOPFLOW
  • TCOPFLOW
  • CMake build system
  • Spack configuration
  • Manual
  • Web docs
  • Other

This MR updates

  • Header files
  • Source code
  • CMake build system
  • Spack configuration
  • Web docs
  • Manual
  • Other

Summary
Previously built ExaGO dependencies on Frontier no longer work after an update to the system software environment. This PR uses a more recent programming environment with the appropriate module loaded.

I documented test failures (similar to previous observations in #89) in issue #152.

@nkoukpaizan nkoukpaizan force-pushed the nicholson/frontier-worldshared-cpe23.12 branch from 31083d4 to e5387c5 Compare July 29, 2024 14:53
@cameronrutherford
Copy link
Contributor

LGTM but we should figure out the path forward for #152 before merging this IMO

Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build and run ExaGO with new dependency management configuration.

I suggest we merge. Issues #152 and #127 are out of scope of this PR and should be addressed separately.

@pelesh
Copy link
Collaborator

pelesh commented Jul 31, 2024

LGTM but we should figure out the path forward for #152 before merging this IMO

#152 does not seem to be caused by this PR, it is just exposed now that we can build and run tests on Frontier. Merging this could speed up debugging and will not affect tests on existing CI pipelines.

@cameronrutherford cameronrutherford merged commit 73445da into develop Aug 1, 2024
@cameronrutherford
Copy link
Contributor

@pelesh I agree, so I merged :)

@nkoukpaizan nkoukpaizan deleted the nicholson/frontier-worldshared-cpe23.12 branch September 24, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants