Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code cleanup: This change removes the blank line from the beginning of libpng source files. #619

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jbowler
Copy link
Contributor

@jbowler jbowler commented Oct 10, 2024

The blank lines are apparently an artefact of an older source control
system. They are not required and look like errors or accidents because
the format of putting a blank line at the start of files is not in
regular use by software developers.

Signed-off-by: John Bowler [email protected]

…f libpng source files.

The blank lines are apparently an artefact of an older source control
system.  They are not required and look like errors or accidents because
the format of putting a blank line at the start of files is not in
regular use by software developers.

Signed-off-by: John Bowler <[email protected]>
@jbowler
Copy link
Contributor Author

jbowler commented Oct 10, 2024

They were all over the place but not consistently so. I'm sure the leading blank line has no semantic significance in any of those files.

This shouldn't cause merge conflicts with any pending pull requests.

@ctruta
Copy link
Member

ctruta commented Oct 11, 2024

Applied, thank you. I applied it both to libpng18 and libpng16.

If you probably noticed, I take the liberty to edit the contributed commit messages, including yours. I hope you don't mind that. You mentioned the Git contribution guidelines, and while I don't follow all of them, I do follow many.
https://git-scm.com/docs/SubmittingPatches
I very much like this statement:
Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behavior.

@ctruta ctruta merged commit 37cc20a into pnggroup:libpng18 Oct 11, 2024
1 check passed
@jbowler jbowler deleted the chore-remove-blank-lines branch October 11, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants