Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering by source (-s) #3

Open
stuartpb opened this issue Apr 8, 2015 · 3 comments
Open

Filtering by source (-s) #3

stuartpb opened this issue Apr 8, 2015 · 3 comments

Comments

@stuartpb
Copy link
Member

stuartpb commented Apr 8, 2015

Per heroku:

 -s, --source SOURCE  # only display logs from the given source

This kind of depends on sorting out how we'll even do sources - I believe heroku has "app" and "router".

@stuartpb stuartpb changed the title Filtering by source (-p) Filtering by source (-s) Apr 8, 2015
@stuartpb
Copy link
Member Author

stuartpb commented Apr 8, 2015

Like the discussion in #5 about limiting lines, this will almost definitely be handled by a post-hoc grep, with possible hinting-by-parameter to the app-logs hook scripts.

@stuartpb
Copy link
Member Author

stuartpb commented Apr 8, 2015

Also like #5, this is warranted (at the command level) because it's filtering lines before taking up bandwidth to send them. Offloading it to the client would be bandwidth-cruel (not to mention kinda kludgy).

@stuartpb
Copy link
Member Author

stuartpb commented Apr 8, 2015

In fact, it could be argued that there's merit for a few more filtering options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant