Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserting source and other fields #10

Open
stuartpb opened this issue Apr 12, 2015 · 1 comment
Open

Inserting source and other fields #10

stuartpb opened this issue Apr 12, 2015 · 1 comment

Comments

@stuartpb
Copy link
Member

As required for #3, #4, (some of) #7, and (probably) #9.

Plugins providing logs need to start inserting a field on the line after the timestamp to distinguish the message's source (probably using sed), matching the format of logs from Heroku.

Heroku just has the "source" that comes after the timestamp; I'm not sure if syslog-style importance would be a user convention or what, but it seems like source is the only field that is necessary.

Maybe the hook name should be changed so as to not lock app-logs into a shortsighted format (allowing new names for new formats in the future)? eg. timestamped-app-logs and timestamped-sourced-app-logs.

@stuartpb
Copy link
Member Author

Per plushu/plushu-app-docker-logs#1, one sensible piece of data to track in sources is the source/level of a log message (something I'm not sure even Heroku tracks atm). Decoration conventions we could follow / take inspiration from:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant