refactored module to add one to many relationship for events to targets

[johnricords]

No description provided.

[lorengordon]

This change is a little confusing to me. Can you clarify the desired use case? My expectation would be that this module would create a single event rule, and associate many targets to that one rule. The variable definition doesn't match that though. So I think something somewhat foundational might be off about the implementation (or my expectation!)...

[lorengordon]

Suggesting a few more changes...

[lorengordon]

Since the focus of this module is creating an event rule, what do you think about simplifying the variable a little, just making the event_rule object the top-level variable? (Also adding the name attribute, as suggested elsewhere) I.e....

variable "event_rule" {
  description = "Object of input configs for the CloudWatch Event Rule"
  type = object({
    name          = string
    description   = optional(string)
    event_pattern = optional(string)

    event_targets = optional(list(object({
      name = string
      arn  = string

      event_bus_name = optional(string)
      role_arn       = optional(string)
      target_id      = optional(string)

      dead_letter_config = optional(object({
        arn = string
      }))

      input_transformer = optional(object({
        input_paths    = optional(map(string))
        input_template = string
      }))
    })), [])
  }))
}