Logic to conditionally-create user.cfg files to support EFI-booted systems.
#490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stuff on (VFAT-formatted) /boot/efi won't accept mode-change attempts
|
|
lorengordon
reviewed
Mar 12, 2024
There was a problem hiding this comment.
I think this isn't quite going to work the way we want... It will execute both cat1.RHEL-08-010140 and cat1.RHEL-08-010150 on every system, both EFI-booted and BIOS-booted systems. The require is used only for ordering, and only cancels depending states if the required state fails. But "no changes" or "skip" are counted as "success". Which means the states operating on grubUserFile, which is the same file in each case, will execute twice.
nuke extra space Co-authored-by: Loren Gordon <[email protected]>
Fix copy-paystah error Co-authored-by: Loren Gordon <[email protected]>
lorengordon
reviewed
Mar 13, 2024
Nuke cruft Co-authored-by: Loren Gordon <[email protected]>
Co-authored-by: Loren Gordon <[email protected]>
lorengordon
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #487