Add PHPStan checks (level 1) #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
force-pushed
the
feature/phpstan-lvl-1
branch
from
aaece15
to
e75205e
Compare
cedric-anne
force-pushed
the
feature/phpstan-lvl-1
branch
from
b5684c0
to
4a4bca2
Compare
trasher
requested changes
Nov 6, 2023
| vendor/bin/parallel-lint --colors --checkstyle --exclude ./vendor/ . | vendor/bin/cs2pr | ||
| - name: "PHP_CodeSniffer" | ||
| run: | | ||
| vendor/bin/phpcs -q --report=checkstyle | vendor/bin/cs2pr |
There was a problem hiding this comment.
They are, but as output is piped to cs2pr, it is actually hard to know it. I will fix this.
cedric-anne
force-pushed
the
feature/phpstan-lvl-1
branch
3 times, most recently
from
9890f4d
to
1eb18b8
Compare
cedric-anne
force-pushed
the
feature/phpstan-lvl-1
branch
from
1eb18b8
to
f11e0b6
Compare
|
I removed usage to |
trasher
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalization of #37 based on shared workflow (https://github.com/glpi-project/plugin-ci-workflows/blob/v1/.github/workflows/continuous-integration.yml)