Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified constructHistory function in PluginFieldsContainer class #681

Merged
merged 9 commits into from
Jul 31, 2023

Conversation

Aeto-J
Copy link
Contributor

@Aeto-J Aeto-J commented Jul 28, 2023

Remove the "find changes" section , changes are already detected by the update function and added to the field object as properties: updates and oldvalues.

@cedric-anne cedric-anne self-requested a review July 28, 2023 12:44
@tomolimo
Copy link
Collaborator

Hello @Aeto-J
I beleive there is a problem here in the commits:
image
Thank you,
Regards,
Tomolimo

@tomolimo tomolimo assigned tomolimo and unassigned tomolimo Jul 31, 2023
@tomolimo tomolimo self-requested a review July 31, 2023 06:14
@cedric-anne cedric-anne merged commit ba0dc99 into pluginsGLPI:develop Jul 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants