phpstan lvl 1

pluginsGLPI · Oct 30, 2023 · 0bdf5e3 · 0bdf5e3
1 parent a1e4395
commit 0bdf5e3
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/inc/containerdisplaycondition.class.php b/inc/containerdisplaycondition.class.php
@@ -198,6 +198,8 @@ private static function getItemtypesForContainer(int $container_id): array
     {
         global $DB;
 
+        $results = [];
+
         $iterator = $DB->request([
             'SELECT' => ['itemtypes'],
             'FROM'   => PluginFieldsContainer::getTable(),
@@ -212,9 +214,9 @@ private static function getItemtypesForContainer(int $container_id): array
             foreach ($itemtypes as $itemtype) {
                 $results[$itemtype] = $itemtype::getTypeName();
             }
-            return $results;
         }
-        return [];
+
+        return $results;
     }
 
 

diff --git a/inc/field.class.php b/inc/field.class.php
@@ -272,7 +272,7 @@ public function prepareInputForAdd($input)
 
             //reject adding for same dropdown on same bloc
             if (!empty($found)) {
-                Session::AddMessageAfterRedirect(__("You cannot add same field 'dropdown' on same bloc", 'fields', false, ERROR));
+                Session::AddMessageAfterRedirect(__("You cannot add same field 'dropdown' on same bloc", 'fields'), false, ERROR);
                 return false;
             }
 
@@ -676,8 +676,8 @@ public function showForm($ID, $options = [])
     {
         $rand = mt_rand();
 
+        $container = new PluginFieldsContainer();
         if (isset($options['parent_id']) && !empty($options['parent_id'])) {
-            $container = new PluginFieldsContainer();
             $container->getFromDB($options['parent_id']);
         } else if (
             isset($options['parent'])
@@ -697,7 +697,7 @@ public function showForm($ID, $options = [])
         }
 
         $this->initForm($ID, $options);
-        $this->showFormHeader($ID, $options);
+        $this->showFormHeader($options);
 
         echo "<tr>";
         echo "<td>" . __("Label") . " : </td>";

diff --git a/inc/inventory.class.php b/inc/inventory.class.php
@@ -39,7 +39,8 @@ public static function updateInventory($params = [])
             $availaibleItemType = ["Computer","Printer","NetworkEquipment"];
             foreach (array_keys($params['inventory_data']) as $itemtype) {
                 if (in_array($itemtype, $availaibleItemType)) {
-                    //retrive items id switch itemtype
+                    $items_id = 0;
+                    //retrieve items id switch itemtype
                     switch ($itemtype) {
                         case Computer::getType():
                              $items_id = $params['computers_id'];
@@ -110,6 +111,7 @@ public static function loadXMLFile($itemtype, $items_id)
         }
 
         //Check if the file exists with the .xml extension (new format)
+        /** @phpstan-ignore-next-line  */
         $file = PLUGIN_FUSIONINVENTORY_XML_DIR . strtolower($itemtype) . "/" . $folder . "/" . $items_id;
         if (file_exists($file . '.xml')) {
             $file .= '.xml';

diff --git a/phpstan.neon b/phpstan.neon
@@ -1,7 +1,7 @@
 parameters:
     parallel:
         maximumNumberOfProcesses: 2
-    level: 0
+    level: 1
     bootstrapFiles:
         - ../../inc/based_config.php
         - setup.php