Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor code cleanup + dev-dependency updates #128

Merged
merged 2 commits into from
Oct 31, 2023
Merged

minor code cleanup + dev-dependency updates #128

merged 2 commits into from
Oct 31, 2023

Conversation

stklcode
Copy link
Contributor

@stklcode stklcode commented Oct 2, 2023 •
edited
Loading

Code cleanup:

  • remove unused private method _get_theme_name()
  • remove unnecessary parenthesis around return
  • use elseif instead of else if

Dev dependency updates:

  • WP Mock 0.5 -> 1.0
  • PHPCS Composer Installer 0.7 -> 1.0
  • WPCS ESLint 14 -> 16
  • some minor patch-level updates

@stklcode
minor code cleanup
ad1eefc 
* remove unused private method _get_theme_name()
* remove unnecessary parenthesis around return
* use "elseif" instead of "else if"
@stklcode stklcode force-pushed the cleanup branch 2 times, most recently from 99b9650 to f0e9bba Compare October 2, 2023 16:03
@stklcode stklcode changed the title minor code cleanup minor code cleanup + dev-dependency updates Oct 2, 2023
@stklcode stklcode added the dependencies Pull requests that update a dependency file label Oct 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stklcode stklcode self-assigned this Oct 20, 2023
Zodiac1978
Zodiac1978 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@Zodiac1978 Zodiac1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stklcode stklcode merged commit 7fd71df into develop Oct 31, 2023
6 checks passed
@stklcode stklcode deleted the cleanup branch October 31, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zodiac1978 Zodiac1978 Zodiac1978 approved these changes

Assignees

@stklcode stklcode

Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stklcode @Zodiac1978