-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace deprecated FILTER_SANITIZE_STRING (#126) #127
Conversation
87964f9
to
938b179
Compare
938b179
to
a6030c5
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
LGTM.
a6030c5
to
5a7e857
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #127 +/- ##
==========================================
Coverage 36.30% 36.30%
Complexity 147 147
==========================================
Files 5 5
Lines 774 774
==========================================
Hits 281 281
Misses 493 493
☔ View full report in Codecov by Sentry. |
resolves #126
In the following method
check_theme_file()
URL sanitization is applied, so we can either useFILTER_SANITIZE_URL
here as well or simply passUNSAFE_RAW
in this case.antivirus/inc/class-antivirus-checkinternals.php
Lines 83 to 87 in e55943c