-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate settings and manual scan in admin ui #107
Conversation
52ab26a
to
c0a5b7f
Compare
This looks great! Just one idea: Maybe we could add a brighter version of the highlight color as a background-color for the row to make it easier to see what line is processed and how is the result (like on the plugins page). For example:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #107 +/- ##
=============================================
- Coverage 35.93% 34.10% -1.84%
- Complexity 151 155 +4
=============================================
Files 5 5
Lines 782 824 +42
=============================================
Hits 281 281
- Misses 501 543 +42
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Rebased on top of the latest develop state. Tested on a real-world 5.9.3 site without any issues. Still looks like the previously attached screenshot. |
Manual theme file scan is not placed in a separate tab. Settings table uses default WP settings styles and the scan results are presented in a WP-like table structure.
Shorten the row header and add descriptive labels directly after the checkboxes to enable certain checks.
1d95c22
to
19ae7e1
Compare
19ae7e1
to
3124506
Compare
3124506
to
266df6c
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not check every single line, so this needs more eyes to check after merging.
LGTM so far.
266df6c
to
4797462
Compare
First step for a UI rework. Addresses #22 and is based on the mockups by @00travelgirl00.
This PR does not introduce any new features and does not change our API, s.t. not all features from the mockups are available yet (theme grouping, last scan timestamp, etc.)
Manual theme file scan is not placed in a separate tab.
Settings table uses default WP settings styles and the scan results are presented in a WP-like table structure.
(could be migrated to settings API which would ease real modularization, but not now)
The first column is yet intentionally left empty. In a followup step I'd like to see grouping the files by theme (or maybe file system hierarchy), so toggle controls should be placed there.
Preview (animated)