Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate settings and manual scan in admin ui #107

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Conversation

stklcode
Copy link
Contributor

@stklcode stklcode commented Apr 10, 2021

First step for a UI rework. Addresses #22 and is based on the mockups by @00travelgirl00.
This PR does not introduce any new features and does not change our API, s.t. not all features from the mockups are available yet (theme grouping, last scan timestamp, etc.)

Manual theme file scan is not placed in a separate tab.

Settings table uses default WP settings styles and the scan results are presented in a WP-like table structure.
(could be migrated to settings API which would ease real modularization, but not now)

The first column is yet intentionally left empty. In a followup step I'd like to see grouping the files by theme (or maybe file system hierarchy), so toggle controls should be placed there.

Preview (animated)

settings tab
scan tab

@stklcode stklcode force-pushed the feature/wpui branch 2 times, most recently from 52ab26a to c0a5b7f Compare April 11, 2021 08:21
@stklcode stklcode added this to the 1.5.0 milestone Apr 11, 2021
@Zodiac1978
Copy link
Member

Zodiac1978 commented May 13, 2021

This looks great!

Just one idea: Maybe we could add a brighter version of the highlight color as a background-color for the row to make it easier to see what line is processed and how is the result (like on the plugins page).

For example:

.av-status-ok {
  background-color: #edfaef !important;
}

@stklcode
Copy link
Contributor Author

stklcode commented May 13, 2021

Good idea. We should darken the font color to the 70% values though, to keep a good contrast ratio and override the default opacity of the code-box, s.t. it's not a redish gray.

Like so:

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #107 (3124506) into develop (b6edc75) will decrease coverage by 1.84%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff              @@
##             develop     #107      +/-   ##
=============================================
- Coverage      35.93%   34.10%   -1.84%     
- Complexity       151      155       +4     
=============================================
  Files              5        5              
  Lines            782      824      +42     
=============================================
  Hits             281      281              
- Misses           501      543      +42     
Impacted Files Coverage Δ
inc/class-antivirus.php 16.06% <0.00%> (-1.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Zodiac1978 Zodiac1978 linked an issue Jul 20, 2021 that may be closed by this pull request
@stklcode
Copy link
Contributor Author

Rebased on top of the latest develop state.

Tested on a real-world 5.9.3 site without any issues. Still looks like the previously attached screenshot.

@pluginkollektiv pluginkollektiv deleted a comment from codecov-io May 18, 2022
Manual theme file scan is not placed in a separate tab.
Settings table uses default WP settings styles and the scan results
are presented in a WP-like table structure.
Shorten the row header and add descriptive labels directly after
the checkboxes to enable certain checks.
@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@Zodiac1978 Zodiac1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not check every single line, so this needs more eyes to check after merging.
LGTM so far.

@stklcode stklcode self-assigned this Oct 31, 2023
@stklcode stklcode merged commit 96050df into develop Oct 31, 2023
5 checks passed
@stklcode stklcode deleted the feature/wpui branch October 31, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make UI more WordPress-like
3 participants