Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty data error #529

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Fix empty data error #529

merged 3 commits into from
Sep 20, 2023

Conversation

Zodiac1978
Copy link
Member

Usage of the core filter pre_comment_user_ip does trigger our empty data check for the IP address if the IP is removed intentionally for GDPR compliance. Switching to own filter.

Fixes #527

Usage of the core filter pre_comment_user_ip does trigger our empty data check for the ip address if the IP is removed intentionallly for GDPR compliance. Switching to own filter.
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@florianbrinkmann florianbrinkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florianbrinkmann florianbrinkmann merged commit 2bf2a59 into master Sep 20, 2023
41 checks passed
@Zodiac1978 Zodiac1978 deleted the 527-fix-empty-data-error branch February 3, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of pre_comment_user_ip is breaking if IP is removed
2 participants