Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare 2.11.4 release #524

Merged
merged 3 commits into from
Sep 3, 2023
Merged

prepare 2.11.4 release #524

merged 3 commits into from
Sep 3, 2023

Conversation

florianbrinkmann
Copy link
Member

@florianbrinkmann florianbrinkmann commented Sep 1, 2023 •
edited
Loading

Closes #523

Zodiac1978
Zodiac1978 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@Zodiac1978 Zodiac1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing the issue + PR!

Just one little detail:
Showing the upgrade notice is not a fix, but an enhancement.

Not really important ...

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@florianbrinkmann
Copy link
Member Author

Showing the upgrade notice is not a fix, but an enhancement.

You’re right, fixed that :)

@florianbrinkmann florianbrinkmann merged commit ab767d7 into master Sep 3, 2023
41 checks passed
@Zodiac1978 Zodiac1978 deleted the 2-11-4 branch February 3, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zodiac1978 Zodiac1978 Zodiac1978 approved these changes

@pfefferle pfefferle Awaiting requested review from pfefferle

@krafit krafit Awaiting requested review from krafit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare 2.11.4 release
2 participants
@florianbrinkmann @Zodiac1978