Fixed some Linux warnings

plugdata-team · Oct 29, 2023 · 9efcb96 · 9efcb96
1 parent d2629d4
commit 9efcb96
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -74,7 +74,7 @@ if(MSVC)
   add_compile_options(/MP /wd4244 /wd4311 /wd4003 /wd4047 /wd4477 /wd4068 /wd4133 /wd4311)
   add_link_options(/ignore:4286 /ignore:4217)
 else()
-  add_compile_options(-Wall -Wstrict-aliasing -Wuninitialized -Wno-conversion -Wno-overloaded-virtual -Wno-sign-compare -Wno-comment)
+  add_compile_options(-Wall -Wstrict-aliasing -Wuninitialized -Wno-conversion -Wno-overloaded-virtual -Wno-sign-compare -Wno-comment -Wno-unknown-pragmas -Wnounused-result)
 endif()
 
 message(STATUS "Preparing documentation")

diff --git a/Libraries/CMakeLists.txt b/Libraries/CMakeLists.txt
@@ -300,8 +300,6 @@ if(CMAKE_C_COMPILER_ID MATCHES "Clang|GNU")
 
     if(CMAKE_C_COMPILER_ID MATCHES "Clang")
         add_compile_options(-Wno-compare-distinct-pointer-types -Wno-implicit-int-conversion)
-    else()
-        add_compile_options(-Wno-discarded-qualifiers)
     endif()
 
     set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-int-conversion -Wno-pointer-sign -Wno-pointer-to-int-cast -Wno-incompatible-pointer-types")

diff --git a/Source/ObjectGrid.cpp b/Source/ObjectGrid.cpp
@@ -383,6 +383,8 @@ Line<int> ObjectGrid::getObjectIndicatorLine(Side side, Rectangle<int> b1, Recta
                 return {b1.getCentreX(), b1.getY(), b2.getCentreX(), b2.getBottom()};
             }
     }
+
+    return {};
 }
 
 void ObjectGrid::clearIndicators()

diff --git a/Source/Tabbar/ResizableTabbedComponent.cpp b/Source/Tabbar/ResizableTabbedComponent.cpp
@@ -96,12 +96,6 @@ void ResizableTabbedComponent::itemDropped(SourceDetails const& dragSourceDetail
         auto patchData = patchWithSize[2].toString();
 
         cnv->dragAndDropPaste(patchData, mousePos, patchSize.x, patchSize.y);
-    } else if (auto docBrowserItem = dynamic_cast<DocumentBrowserItem*>(dragSourceDetails.sourceComponent.get())) {
-        // ALEX TODO: not implemented
-        // we also have an issue that the DocumentBrowserItem is a TreeViewItem which is a Juce class that uses DragAndDropContainer!
-        // so we wil need to somehow get that using ZoomableDragAndDropContainer?
-        // browser->pd->loadPatch(file);
-        // SettingsFile::getInstance()->addToRecentlyOpened(file);
     }
 }
-Original file line number
+Diff line change
@@ Expand Up @@
                     return {b1.getCentreX(), b1.getY(), b2.getCentreX(), b2.getBottom()};
                 }
         }
+        return {};
     }
     void ObjectGrid::clearIndicators()
@@ Expand Down @@